Fix issue with getting correct container layout#140
Open
jcurtis wants to merge 1 commit intogitim:masterfrom
Open
Fix issue with getting correct container layout#140jcurtis wants to merge 1 commit intogitim:masterfrom
jcurtis wants to merge 1 commit intogitim:masterfrom
Conversation
`_onUpdateLayouts` is triggering before the content is actually rendered so the containerLayout width and height values are always incorrect
chrisbeatty00
approved these changes
Jan 15, 2019
louiscurtis
approved these changes
Jan 15, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
_onUpdateLayoutsis triggering before the content is actually renderedso the containerLayout width and height values are always incorrect.
This was causing some weird glitches with the auto scrolling. There's probably a better way to fix the root problem but here's a quick fix.